chore: adds link to discussion on omitting EIP712Domain validation

akitda · Mar 21, 2022 · 5097f42 · 5097f42
1 parent 1f3af87
commit 5097f42
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/dapps/react-dapp-v2-with-ethers/src/App.tsx b/dapps/react-dapp-v2-with-ethers/src/App.tsx
@@ -191,6 +191,7 @@ export default function App() {
 
     // Separate `EIP712Domain` type from remaining types to verify, otherwise `ethers.utils.verifyTypedData`
     // will throw due to "unused" `EIP712Domain` type.
+    // See: https://github.com/ethers-io/ethers.js/issues/687#issuecomment-714069471
     const { EIP712Domain, ...nonDomainTypes }: Record<string, TypedDataField[]> =
       eip712.example.types;
 

diff --git a/dapps/react-dapp-v2-with-web3js/src/App.tsx b/dapps/react-dapp-v2-with-web3js/src/App.tsx
@@ -199,6 +199,7 @@ export default function App() {
 
     // Separate `EIP712Domain` type from remaining types to verify, otherwise `ethers.utils.verifyTypedData`
     // will throw due to "unused" `EIP712Domain` type.
+    // See: https://github.com/ethers-io/ethers.js/issues/687#issuecomment-714069471
     const { EIP712Domain, ...nonDomainTypes }: Record<string, TypedDataField[]> =
       eip712.example.types;
 

diff --git a/dapps/react-dapp-v2/src/contexts/JsonRpcContext.tsx b/dapps/react-dapp-v2/src/contexts/JsonRpcContext.tsx
@@ -284,6 +284,7 @@ export function JsonRpcContextProvider({ children }: { children: ReactNode | Rea
 
       // Separate `EIP712Domain` type from remaining types to verify, otherwise `ethers.utils.verifyTypedData`
       // will throw due to "unused" `EIP712Domain` type.
+      // See: https://github.com/ethers-io/ethers.js/issues/687#issuecomment-714069471
       const { EIP712Domain, ...nonDomainTypes }: Record<string, TypedDataField[]> =
         eip712.example.types;