Skip to content

Commit

Permalink
Remove keccak256 crate and migrate keccak plain to eth-types (privacy…
Browse files Browse the repository at this point in the history
…-scaling-explorations#1440)

### Description

- We remove the keccak256 crate.
- We migrate the keccak256 plain implementation to the eth-types crate.

As we migrate keccak circuit to the zkevm-crate, most of the functions
left in keccak256 crate are unused except of the plain keccak hash
implementation.

Most of the crates in the codebase depend on keccak256 crate because
they use the plain keccak hash. The plain keccak hash is only 300 lines
big. It would be beneficial to keep a plain implementation for people to
audit the optimized keccak circuit.

### Type of change

Bug fix (non-breaking change which fixes an issue)
  • Loading branch information
ChihChengLiang authored May 31, 2023
1 parent 96d2e3c commit 73b2aeb
Show file tree
Hide file tree
Showing 22 changed files with 141 additions and 1,471 deletions.
2 changes: 0 additions & 2 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ crate-geth-utils:
- geth-utils/**/*
crate-integration-tests:
- integration-tests/**/*
crate-keccak:
- keccak256/**/*
crate-mock:
- mock/**/*
crate-prover:
Expand Down
Loading

0 comments on commit 73b2aeb

Please sign in to comment.