Skip to content

Commit

Permalink
Deprecate insufficiently traded assets
Browse files Browse the repository at this point in the history
 - Remove assets from META-INF/services/bisq.asset.Asset
 - Preserve asset types but mark as @deprecated
 - @ignore asset tests

Preserving the types is important from a compatibility perspective.
Users who have traded these assets in the past, however few there may
be, need to be able to classload the asset type(s) in order to avoid
errors when browsing through their trade portfolio history.
  • Loading branch information
cbeams committed Nov 6, 2018
1 parent 85caf02 commit 34a82ba
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .idea/codeStyles/Project.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions assets/src/main/java/bisq/asset/coins/Koto.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@

import java.util.Arrays;

/**
* @deprecated for insufficent trading
*/
@Deprecated(since = "0.9.0")
public class Koto extends Coin {

public Koto() {
Expand Down
4 changes: 4 additions & 0 deletions assets/src/main/java/bisq/asset/coins/Obsidian.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
import bisq.asset.Coin;
import bisq.asset.NetworkParametersAdapter;

/**
* @deprecated for insufficent trading
*/
@Deprecated(since = "0.9.0")
public class Obsidian extends Coin {

public Obsidian() {
Expand Down
2 changes: 0 additions & 2 deletions assets/src/main/resources/META-INF/services/bisq.asset.Asset
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ bisq.asset.coins.InfinityEconomics
bisq.asset.coins.Instacash
bisq.asset.coins.InternetOfPeople
bisq.asset.coins.Kekcoin
bisq.asset.coins.Koto
bisq.asset.coins.Kumacoin
bisq.asset.coins.LBRY
bisq.asset.coins.Lisk
Expand Down Expand Up @@ -95,7 +94,6 @@ bisq.asset.coins.Nilu
bisq.asset.coins.Nimiq
bisq.asset.coins.NuBits
bisq.asset.coins.Nxt
bisq.asset.coins.Obsidian
bisq.asset.coins.Octocoin
bisq.asset.coins.Particl
bisq.asset.coins.PepeCash
Expand Down
3 changes: 3 additions & 0 deletions assets/src/test/java/bisq/asset/coins/KotoTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@

import bisq.asset.AbstractAssetTest;

import org.junit.Ignore;
import org.junit.Test;

@Ignore
@Deprecated
public class KotoTest extends AbstractAssetTest {

public KotoTest() {
Expand Down
3 changes: 3 additions & 0 deletions assets/src/test/java/bisq/asset/coins/ObsidianTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@

import bisq.asset.AbstractAssetTest;

import org.junit.Ignore;
import org.junit.Test;

@Ignore
@Deprecated
public class ObsidianTest extends AbstractAssetTest {

public ObsidianTest() {
Expand Down

0 comments on commit 34a82ba

Please sign in to comment.