Skip to content

Commit

Permalink
ACPI: Add _OST support for ACPI container hotplug
Browse files Browse the repository at this point in the history
Changed container_notify_cb() to call ACPI _OST method when ACPI
container hotplug operation has completed. Slightly restructured
the code with the same logic. The function sets eject_pending bit
for an eject request since it does not initiate hot-remove operation.
This bit is checked by the sysfs eject handler to determine if the
request is originated from an ACPI eject notification.

Signed-off-by: Toshi Kani <[email protected]>
Signed-off-by: Len Brown <[email protected]>
  • Loading branch information
Toshi Kani authored and lenb committed Jun 4, 2012
1 parent b1f00de commit 0c67dc2
Showing 1 changed file with 28 additions and 15 deletions.
43 changes: 28 additions & 15 deletions drivers/acpi/container.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,7 @@ static void container_notify_cb(acpi_handle handle, u32 type, void *context)
int result;
int present;
acpi_status status;


present = is_device_present(handle);
u32 ost_code = ACPI_OST_SC_NON_SPECIFIC_FAILURE; /* default */

switch (type) {
case ACPI_NOTIFY_BUS_CHECK:
Expand All @@ -169,32 +167,47 @@ static void container_notify_cb(acpi_handle handle, u32 type, void *context)
printk(KERN_WARNING "Container driver received %s event\n",
(type == ACPI_NOTIFY_BUS_CHECK) ?
"ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK");

present = is_device_present(handle);
status = acpi_bus_get_device(handle, &device);
if (present) {
if (ACPI_FAILURE(status) || !device) {
result = container_device_add(&device, handle);
if (!result)
kobject_uevent(&device->dev.kobj,
KOBJ_ONLINE);
else
printk(KERN_WARNING
"Failed to add container\n");
}
} else {
if (!present) {
if (ACPI_SUCCESS(status)) {
/* device exist and this is a remove request */
device->flags.eject_pending = 1;
kobject_uevent(&device->dev.kobj, KOBJ_OFFLINE);
return;
}
break;
}

if (!ACPI_FAILURE(status) || device)
break;

result = container_device_add(&device, handle);
if (result) {
printk(KERN_WARNING "Failed to add container\n");
break;
}

kobject_uevent(&device->dev.kobj, KOBJ_ONLINE);
ost_code = ACPI_OST_SC_SUCCESS;
break;

case ACPI_NOTIFY_EJECT_REQUEST:
if (!acpi_bus_get_device(handle, &device) && device) {
device->flags.eject_pending = 1;
kobject_uevent(&device->dev.kobj, KOBJ_OFFLINE);
return;
}
break;

default:
break;
/* non-hotplug event; possibly handled by other handler */
return;
}

/* Inform firmware that the hotplug operation has completed */
(void) acpi_evaluate_hotplug_ost(handle, type, ost_code, NULL);
return;
}

Expand Down

0 comments on commit 0c67dc2

Please sign in to comment.