Skip to content

Commit

Permalink
Revert "openvswitch: potential NULL deref in sample()"
Browse files Browse the repository at this point in the history
This reverts commit 5b3e7e6.

The problem that the original commit was attempting to fix can
never happen in practice because validation is done one a per-flow
basis rather than a per-packet basis.  Adding additional checks at
runtime is unnecessary and inconsistent with the rest of the code.

CC: Dan Carpenter <[email protected]>
Signed-off-by: Jesse Gross <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
jessegross authored and davem330 committed Jul 27, 2012
1 parent 505fbcf commit 6081030
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions net/openvswitch/actions.c
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,6 @@ static int sample(struct datapath *dp, struct sk_buff *skb,
}
}

if (!acts_list)
return 0;

return do_execute_actions(dp, skb, nla_data(acts_list),
nla_len(acts_list), true);
}
Expand Down

0 comments on commit 6081030

Please sign in to comment.