lguest: fix pending interrupt test.

Denys says: TEST with zero will always set ZF. Thus, "jnz send_interrupts" never jumps. We get interrupts regularly enough that this didn't cause immediate problems. Reported-by: Denys Vlasenko <[email protected]> Signed-off-by: Rusty Russell <[email protected]>
akvadrako · Mar 20, 2015 · 88ad1a1 · 88ad1a1
1 parent c586165
commit 88ad1a1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/arch/x86/lguest/head_32.S b/arch/x86/lguest/head_32.S
@@ -84,7 +84,7 @@ ENTRY(lg_irq_enable)
 	 * set lguest_data.irq_pending to X86_EFLAGS_IF.  If it's not zero, we
 	 * jump to send_interrupts, otherwise we're done.
 	 */
-	testl $0, lguest_data+LGUEST_DATA_irq_pending
+	cmpl $0, lguest_data+LGUEST_DATA_irq_pending
 	jnz send_interrupts
 	/*
 	 * One cool thing about x86 is that you can do many things without using