-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add NbIcon on NbWindow title #2686
Closed
Salvatore-Als
wants to merge
14
commits into
akveo:master
from
Salvatore-Als:feat/add-NbIcon-on-NbWindow
Closed
add NbIcon on NbWindow title #2686
Salvatore-Als
wants to merge
14
commits into
akveo:master
from
Salvatore-Als:feat/add-NbIcon-on-NbWindow
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2686 +/- ##
==========================================
- Coverage 77.82% 77.78% -0.04%
==========================================
Files 262 262
Lines 8229 8228 -1
Branches 896 896
==========================================
- Hits 6404 6400 -4
- Misses 1550 1553 +3
Partials 275 275
|
2 tasks
UP. I think it would be a good idea to add it natively to nebular :) |
Closed by #2915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
This feature allows to add icons in the title of a window.
I made this addition for a personal need, asked few month ago #2576