-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#24] Move Theme Switcher to User-Nav on Mobile #25
[#24] Move Theme Switcher to User-Nav on Mobile #25
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now, it only works when i click on the theme toggle. instead it should work when i click anywhere in the dropdown item.
also, the theme toggle icon is too large. it should be the same size as the other icons in the dropdown menu.
Addressing your review. View activity logs for details. |
@alanagoyal I've addressed your review. Add another review if minor changes are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not modify theme-toggle.tsx
instead, use the same sun and moon icons and use the same logic to switch the theme. remember the dropdown item should look the same as the other dropdown items with the icon and span text
Addressing your review. View activity logs for details. |
@alanagoyal I've addressed your review, but the automated checks are failing.. If the PR is still not correct, consider closing it. This will improve my future PRs. |
This update enhances the mobile user experience by integrating the
ThemeToggle
component directly into theUserNav
as a dropdown menu item. It is carefully positioned under the 'Support' option and is designed with a focus on maintaining consistency in appearance and functionality with existingUserNav
items.Key aspects of this change include:
This modification effectively simplifies the theme toggling process on mobile devices, encouraging user interaction and contributing to a more dynamic and adaptable user interface.
Tips: