Update number filter to match the string behavior on undefined type

alanbem · Aug 27, 2011 · cf8361a · cf8361a
1 parent f6ea822
commit cf8361a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Filter/ORM/NumberFilter.php b/Filter/ORM/NumberFilter.php
@@ -24,14 +24,16 @@ class NumberFilter extends Filter
      */
     public function filter($queryBuilder, $alias, $field, $data)
     {
-        if (!$data || !is_array($data) || !array_key_exists('type', $data) || !array_key_exists('value', $data)) {
+        if (!$data || !is_array($data) || !array_key_exists('value', $data)) {
             return;
         }
 
-        $operator = $this->getOperator((int) $data['type']);
+        $type = isset($data['type']) ? $data['type'] : false;
+
+        $operator = $this->getOperator($type);
 
         if (!$operator) {
-            return;
+            $operator = '=';
         }
 
         // c.name > '1' => c.name OPERATOR :FIELDNAME

diff --git a/Tests/Filter/ORM/NumberFilterTest.php b/Tests/Filter/ORM/NumberFilterTest.php
@@ -53,13 +53,15 @@ public function testFilter()
         $filter->filter($builder, 'alias', 'field', array('type' => NumberType::TYPE_GREATER_THAN, 'value' => 42));
         $filter->filter($builder, 'alias', 'field', array('type' => NumberType::TYPE_LESS_EQUAL, 'value' => 42));
         $filter->filter($builder, 'alias', 'field', array('type' => NumberType::TYPE_LESS_THAN, 'value' => 42));
+        $filter->filter($builder, 'alias', 'field', array('value' => 42));
 
         $expected = array(
             'alias.field = :field_name',
             'alias.field >= :field_name',
             'alias.field > :field_name',
             'alias.field <= :field_name',
-            'alias.field < :field_name'
+            'alias.field < :field_name',
+            'alias.field = :field_name',
         );
 
         $this->assertEquals($expected, $builder->query);