Implement scandir() #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As apparently intended years ago by the original author
Instead prints "failed to access <path"
|
Thanks! It's nice to see someone else using this. This is definitely worth it for the speedup, but when I did a quick comparison, I saw a problem with the text rendering off-center for leaf nodes. I'm not sure how this change would affect that. I imagine you haven't encountered this? I'll look into it when I get a chance. |
|
Sorry for the, uh, delay on this. I just quickly tried out scandir again and it's marginally slower than listdir on my machine. Is the benefit for you just reducing extra system calls? Or do you see a speed improvement with scandir? |
alanbernstein
force-pushed
the
master
branch
2 times, most recently
from
8563703 to
3a179ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.scandir() eliminates the need to use two system calls to get size of files. As apparently intended by the original author.
I used this software for years, and did a few edits of my own, finally got around to send it to repository. Thanks for making this.