Skip to content

Commit

Permalink
OWNER_ALIASES: Converge on sig-compute again
Browse files Browse the repository at this point in the history
Without much thinking sig-node got introduced before.
But in order to change incremenetally, we only use sig-compute by now, and the
discussion about a potential split (into node and cluster) is deferred.
Keeping sig-compute also helps to keep ownership of mainy tests clear.

Signed-off-by: Fabian Deutsch <[email protected]>
  • Loading branch information
fabiand committed Mar 5, 2024
1 parent ec95a25 commit 63aeb39
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
5 changes: 3 additions & 2 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,11 @@ aliases:
# SIG Compute
# Owns everything which is taking place on a node, for example
# (but not limited to) groups, SELinux, node labels, …
# And everything on the cluster level such as RBAC, controller, …
#
sig-node-approvers:
sig-compute-approvers:
- jean-edouard
sig-node-reviewers:
sig-compute-reviewers:
- victortoso

#
Expand Down
6 changes: 3 additions & 3 deletions pkg/handler-launcher-com/OWNERS
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# See the OWNERS docs at https://go.k8s.io/owners
reviewers:
- sig-node-reviewers
- sig-compute-reviewers
approvers:
- sig-node-approvers
- sig-compute-approvers
labels:
- area/virt-handler
- area/virt-launcher
- sig/node
- sig/compute
6 changes: 3 additions & 3 deletions pkg/virt-handler/OWNERS
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners
reviewers:
- sig-node-reviewers
- sig-compute-reviewers
approvers:
- sig-node-approvers
- sig-compute-approvers
labels:
- area/virt-handler
- sig/node
- sig/compute

0 comments on commit 63aeb39

Please sign in to comment.