Skip to content

Commit

Permalink
Update clang7 CI jobs to clang9 (pytorch#108339)
Browse files Browse the repository at this point in the history
This PR updates the remaining clang7 CI job to clang9. However, I have no permission to push the new docker image so Android CI tests would fail.
Pull Request resolved: pytorch#108339
Approved by: https://github.com/ezyang
  • Loading branch information
cyyever authored and pytorchmergebot committed Sep 5, 2023
1 parent c99a70c commit bae14b3
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 20 deletions.
4 changes: 2 additions & 2 deletions .ci/docker/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@ case "$image" in
CONDA_CMAKE=yes
ONNX=yes
;;
pytorch-linux-focal-py3-clang7-android-ndk-r19c)
pytorch-linux-focal-py3-clang9-android-ndk-r19c)
ANACONDA_PYTHON_VERSION=3.8
CLANG_VERSION=7
CLANG_VERSION=9
LLVMDEV=yes
PROTOBUF=yes
ANDROID=yes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_android-full-build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ jobs:
# run gradle buildRelease
(echo "./.circleci/scripts/build_android_gradle.sh" | docker exec \
-e BUILD_ENVIRONMENT="pytorch-linux-focal-py3-clang7-android-ndk-r19c-gradle-build" \
-e BUILD_ENVIRONMENT="pytorch-linux-focal-py3-clang9-android-ndk-r19c-gradle-build" \
-e MAX_JOBS="$(nproc --ignore=2)" \
-e AWS_DEFAULT_REGION \
-e PR_NUMBER \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- docker-image-name: pytorch-linux-focal-rocm-n-1-py3
- docker-image-name: pytorch-linux-focal-rocm-n-py3
- docker-image-name: pytorch-linux-jammy-cuda11.8-cudnn8-py3.8-clang12
- docker-image-name: pytorch-linux-focal-py3-clang7-android-ndk-r19c
- docker-image-name: pytorch-linux-focal-py3-clang9-android-ndk-r19c
- docker-image-name: pytorch-linux-jammy-py3.8-gcc11
- docker-image-name: pytorch-linux-jammy-py3.8-gcc11-inductor-benchmarks
- docker-image-name: pytorch-linux-jammy-py3-clang12-asan
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,12 @@ jobs:
{ config: "default", shard: 1, num_shards: 1 },
]}
linux-focal-py3-clang7-mobile-custom-build-static:
name: linux-focal-py3-clang7-mobile-custom-build-static
linux-focal-py3-clang9-mobile-custom-build-static:
name: linux-focal-py3-clang9-mobile-custom-build-static
uses: ./.github/workflows/_linux-build.yml
with:
build-environment: linux-focal-py3-clang7-mobile-custom-build-static
docker-image-name: pytorch-linux-focal-py3-clang7-android-ndk-r19c
build-environment: linux-focal-py3-clang9-mobile-custom-build-static
docker-image-name: pytorch-linux-focal-py3-clang9-android-ndk-r19c
build-generates-artifacts: false
test-matrix: |
{ include: [
Expand Down Expand Up @@ -317,23 +317,23 @@ jobs:
{ config: "default", shard: 1, num_shards: 1, runner: "linux.4xlarge.nvidia.gpu" },
]}
linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single:
name: linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single
linux-focal-py3-clang9-android-ndk-r19c-gradle-custom-build-single:
name: linux-focal-py3-clang9-android-ndk-r19c-gradle-custom-build-single
uses: ./.github/workflows/_android-build-test.yml
with:
build-environment: linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single
docker-image-name: pytorch-linux-focal-py3-clang7-android-ndk-r19c
build-environment: linux-focal-py3-clang9-android-ndk-r19c-gradle-custom-build-single
docker-image-name: pytorch-linux-focal-py3-clang9-android-ndk-r19c
test-matrix: |
{ include: [
{ config: "default", shard: 1, num_shards: 1, runner: "linux.2xlarge" },
]}
linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single-full-jit:
name: linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single-full-jit
linux-focal-py3-clang9-android-ndk-r19c-gradle-custom-build-single-full-jit:
name: linux-focal-py3-clang9-android-ndk-r19c-gradle-custom-build-single-full-jit
uses: ./.github/workflows/_android-build-test.yml
with:
build-environment: linux-focal-py3-clang7-android-ndk-r19c-gradle-custom-build-single-full-jit
docker-image-name: pytorch-linux-focal-py3-clang7-android-ndk-r19c
build-environment: linux-focal-py3-clang9-android-ndk-r19c-gradle-custom-build-single-full-jit
docker-image-name: pytorch-linux-focal-py3-clang9-android-ndk-r19c
test-matrix: |
{ include: [
{ config: "default", shard: 1, num_shards: 1, runner: "linux.2xlarge" },
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/trunk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,12 @@ jobs:
{ config: "default", shard: 1, num_shards: 1 },
]}
pytorch-linux-focal-py3-clang7-android-ndk-r19c-build:
name: pytorch-linux-focal-py3-clang7-android-ndk-r19c-build
pytorch-linux-focal-py3-clang9-android-ndk-r19c-build:
name: pytorch-linux-focal-py3-clang9-android-ndk-r19c-build
uses: ./.github/workflows/_android-full-build-test.yml
with:
build-environment: pytorch-linux-focal-py3-clang7-android-ndk-r19c-build
docker-image-name: pytorch-linux-focal-py3-clang7-android-ndk-r19c
build-environment: pytorch-linux-focal-py3-clang9-android-ndk-r19c-build
docker-image-name: pytorch-linux-focal-py3-clang9-android-ndk-r19c
test-matrix: |
{ include: [
{ config: "default", shard: 1, num_shards: 1, runner: "linux.2xlarge" },
Expand Down

0 comments on commit bae14b3

Please sign in to comment.