Skip to content

Commit

Permalink
memblock: Fix include breakages caused by 24aa078
Browse files Browse the repository at this point in the history
24aa078 (memblock, x86: Replace memblock_x86_reserve/free_range()
with generic ones) removed arch/x86/include/asm/memblock.h and dropped
its inclusion from include/linux/memblock.h which breaks other
architectures which depended on the generic memblock.h pulling in the
arch specific one.

However, the proper fix isn't adding back the asm inclusion.  memblock
doesn't have any arch dependent part and doesn't need arch specific
header file and asm/memblock.h files are either practically empty or
contain mostly unrelated arch specific stuff.

* In microblaze, sh, powerpc, sparc and openrisc, asm/memblock.h is
  either empty or just contains unused MEMBLOCK_DBG() macro.  Remove
  them.

* In arm and unicore32, asm/memblock.h contains arch specific stuff.
  Include it directly from its users.  It might be a good idea to
  rename the header file to avoid confusion.

Signed-off-by: Tejun Heo <[email protected]>
Reported-by: "H. Peter Anvin" <[email protected]>
Cc: Yinghai Lu <[email protected]>
Cc: Russell King <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mundt <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Guan Xuetao <[email protected]>
  • Loading branch information
htejun committed Dec 8, 2011
1 parent d4bbf7e commit 1c16d24
Show file tree
Hide file tree
Showing 10 changed files with 5 additions and 58 deletions.
1 change: 1 addition & 0 deletions arch/arm/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
#include <asm/mach/time.h>
#include <asm/traps.h>
#include <asm/unwind.h>
#include <asm/memblock.h>

#if defined(CONFIG_DEPRECATED_PARAM_STRUCT)
#include "compat.h"
Expand Down
1 change: 1 addition & 0 deletions arch/arm/mm/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

#include <asm/mach/arch.h>
#include <asm/mach/map.h>
#include <asm/memblock.h>

#include "mm.h"

Expand Down
14 changes: 0 additions & 14 deletions arch/microblaze/include/asm/memblock.h

This file was deleted.

24 changes: 0 additions & 24 deletions arch/openrisc/include/asm/memblock.h

This file was deleted.

8 changes: 0 additions & 8 deletions arch/powerpc/include/asm/memblock.h

This file was deleted.

4 changes: 0 additions & 4 deletions arch/sh/include/asm/memblock.h

This file was deleted.

8 changes: 0 additions & 8 deletions arch/sparc/include/asm/memblock.h

This file was deleted.

1 change: 1 addition & 0 deletions arch/unicore32/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
#include <asm/traps.h>
#include <asm/memblock.h>

#include "setup.h"

Expand Down
1 change: 1 addition & 0 deletions arch/unicore32/mm/init.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <asm/setup.h>
#include <asm/sizes.h>
#include <asm/tlb.h>
#include <asm/memblock.h>
#include <mach/map.h>

#include "mm.h"
Expand Down
1 change: 1 addition & 0 deletions arch/unicore32/mm/mmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <asm/setup.h>
#include <asm/sizes.h>
#include <asm/tlb.h>
#include <asm/memblock.h>

#include <mach/map.h>

Expand Down

0 comments on commit 1c16d24

Please sign in to comment.