Skip to content

Commit

Permalink
arch/arm/mach-omap2/dpll3xxx.c: drop if around WARN_ON
Browse files Browse the repository at this point in the history
Just use WARN_ON rather than an if containing only WARN_ON(1).

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@
- if (e) WARN_ON(1);
+ WARN_ON(e);
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
  • Loading branch information
JuliaLawall authored and tmlind committed Dec 17, 2012
1 parent 7eae44f commit f64d204
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arch/arm/mach-omap2/dpll3xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,7 @@ int omap3_noncore_dpll_set_rate(struct clk_hw *hw, unsigned long rate,
if (!cpu_is_omap44xx() && !cpu_is_omap3630()) {
freqsel = _omap3_dpll_compute_freqsel(clk,
dd->last_rounded_n);
if (!freqsel)
WARN_ON(1);
WARN_ON(!freqsel);
}

pr_debug("%s: %s: set rate: locking rate to %lu.\n",
Expand Down

0 comments on commit f64d204

Please sign in to comment.