cmd/utils: handle git commit a bit safer for user specified strings (e…

…thereum#15790) * cmd/utils/flags.go: Applying a String len guard for the gitCommit param of the NewApp() * cmd/utils: remove redundant clause in if condition
albrow · Jan 3, 2018 · 7a59a93 · 7a59a93
1 parent 762f3a4
commit 7a59a93
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go
@@ -96,7 +96,7 @@ func NewApp(gitCommit, usage string) *cli.App {
 	//app.Authors = nil
 	app.Email = ""
 	app.Version = params.Version
-	if gitCommit != "" {
+	if len(gitCommit) >= 8 {
 		app.Version += "-" + gitCommit[:8]
 	}
 	app.Usage = usage