New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns4 and dns6 should accept lists of servers instead of strings #6

Open

gwojtak wants to merge 1 commit into alcamie101:master from gwojtak:master

gwojtak commented Mar 31, 2017 •

edited

Loading

I believe it makes more sense to store the separate nameservers in ansible as a list variable, ie:

nameservers:
- 8.8.8.8
- 8.8.4.4

and have the module do the work to convert it to something nmcli can parse (ie, "8.8.8.8,8.8.4.4")

When doing a dns4 or dns6 change, the module errors out unless type is specified, so I added a note to the docs stating such.


          dns4 and dns6 should accept lists of servers instead of strings

d87c1ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet