Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix docs includes & region syntax #1407

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Conversation

jakehobbs
Copy link
Member

@jakehobbs jakehobbs commented Mar 3, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on updating comment syntax in the smartAccountClient.ts file and correcting the references in the documentation to ensure consistency in the codebase.

Detailed summary

  • Changed comment syntax from //#region to // [!region and //#endregion to // [!endregion in smartAccountClient.ts.
  • Updated the references in documentation from # to : for consistency in UserOperationReceipt, UserOperationRequest, UserOperationResponse, and UserOperationStruct.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:53pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:53pm

Copy link

graphite-app bot commented Mar 3, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Collaborator

@adamegyed adamegyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing.

At some point in the future we should re-design this page, to have a better type description - right now it just wraps SmartAccountClientActions, which wraps BaseSmartAccountClientActions, which doesn't have a type definition. But that's out of scope for this task.
Screenshot 2025-03-03 at 4 44 21 PM

@jakehobbs jakehobbs merged commit 1c1759b into main Mar 3, 2025
7 checks passed
@jakehobbs jakehobbs deleted the jake/fix-vocs-includes branch March 3, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants