feat: impl stampler, tek manager, etc #1408
Conversation
andysim3d
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
adamegyed,
howydev,
Zer0dot,
jaypaik,
Blu-J,
noam-alchemy,
jakehobbs and
archit2407
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
andysim3d
changed the title
There was a problem hiding this comment.
Nice yea this looks good to me mostly. Only feedback is around making sure we can handle the case where someone might want to:
- use our code to generate a KeysetHandle for a TEK that they then would store externally
- use externally stored TEK to get an instance of the stamper / signer later
account-kit/java/signer-sdk/src/main/java/com/alchemy/aa/Stampler.java
Outdated
Show resolved
Hide resolved
| * Creates a new TEK via HpkeTEKManager or returns the existing one | ||
| * @return TEK public key | ||
| */ | ||
| public String initTek(){ |
There was a problem hiding this comment.
this should probably be static. One possible flow is creating a TEK and storing it somewhere, so it could be that this stamper is initialized with a TEK that's externally managed
account-kit/java/signer-sdk/src/main/java/com/alchemy/aa/Stampler.java
Outdated
Show resolved
Hide resolved
| this.bundlePrivateKey = Utilities.bytesToHex(privateKeyBytes).toLowerCase(Locale.ROOT).toCharArray(); | ||
| this.bundlePublicKey = Utilities.bytesToHex(publicKeyBytes).toLowerCase(Locale.ROOT).toCharArray(); |
There was a problem hiding this comment.
is it more convenient / efficient to just skip this conversion and store the keys as byte[] in this class?
account-kit/java/signer-sdk/src/main/java/com/alchemy/aa/Stampler.java
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
|
|
||
| byte[] privateKeyBytes = Utilities.HexToBytes(signingKeyHex); |
There was a problem hiding this comment.
ah yea here is what I was thinking we could skip if the stamper just stores the keys as bytes
account-kit/java/signer-sdk/src/main/java/com/alchemy/aa/core/TEKManager.java
Outdated
Show resolved
Hide resolved
| public Stamper() { | ||
| this(/* tekManager= */null); | ||
| } |
There was a problem hiding this comment.
is this a construction flow we want to enable? you kinda always need a TEK manager to make this work.
I think we should have the following in addition to the one above:
public Stamper(targetPrivateKeyHex: String) {}
public Stamper(targetPrivateKey: byte[]) {}
public Stamper(targetKeySet: KeysetHandle) {}
// maybe these too?
public Stamper(targetPrivateKeyHex: String, bundle: String) {}
public Stamper(targetPrivateKey: byte[], bundle: String) {}
public Stamper(targetKeySet: KeysetHandle, bundle: String) {}
| public String initTek() throws GeneralSecurityException, InvalidProtocolBufferException { | ||
| byte[] tekPublicKeyBytes = this.tekManager.createTEK().getPublicKeyBytes().toByteArray(); | ||
| return Hex.encode(tekPublicKeyBytes); | ||
|
|
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces a new
Signer Java SDKfor handling cryptographic operations, including signing and verification of payloads. It adds essential classes for exception handling, key management, and testing, while updating the project configuration and dependencies.Detailed summary
NoTEKException,NoInjectedBundleException, andStamperNotInitializedExceptionclasses for error handling.TEKManagerclass for managing encryption keys.Stamperclass for signing payloads.StamperTestsfor unit testing functionality.pom.xmlwith new dependencies and project metadata.README.md.