-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump reth deps #933
base: main
Are you sure you want to change the base?
Conversation
@0xOsiris is the large diff here because of a |
Yes, |
Looks like the It seems alloy has deprecated some fields, we're actively updating alloy in another PR, so this should get fixed once that merges #930. For the Cargo Deny failure, its likely we just have to add |
Update here, we're still figuring out what we need to do (if anything) to change our license to incorporate these denied crates. Trying to get this done ASAP. |
This should clear up the deny issue, also includes the |
Awesome, just merged upstream! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you have changes to the git submodules. You should revert that change back to head and then run git update submodules
to get your local updated and this diff should go away.
(I hate submodules and we're looking at ways to remove these, but they're currently very useful for testing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for dealing with all the back-and-forth here!
[Closes/Fixes] #
Proposed Changes
This PR bumps the
reth-tasks
dependency inrundler
tov1.1.4
. This makesrundler
crates that havereth-tasks
as a dependency compatible with projects depending on the latest version of Reth.