Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump reth deps #933

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: bump reth deps #933

wants to merge 4 commits into from

Conversation

0xOsiris
Copy link

@0xOsiris 0xOsiris commented Dec 11, 2024

[Closes/Fixes] #

Proposed Changes

This PR bumps the reth-tasks dependency in rundler to v1.1.4. This makes rundler crates that have reth-tasks as a dependency compatible with projects depending on the latest version of Reth.

@dancoombs
Copy link
Collaborator

@0xOsiris is the large diff here because of a cargo update? Were there further conflicts in when trying to upgrade reth-tasks?

@0xOsiris
Copy link
Author

@0xOsiris is the large diff here because of a cargo update? Were there further conflicts in when trying to upgrade reth-tasks?

Yes, cargo build initially failed but a cargo update patched the lock file

@dancoombs
Copy link
Collaborator

Looks like the cargo update pulled in some changes that broke our lints.

It seems alloy has deprecated some fields, we're actively updating alloy in another PR, so this should get fixed once that merges #930.

For the Cargo Deny failure, its likely we just have to add Unicode-3.0 to our allowlist. Let me check internally.

@dancoombs
Copy link
Collaborator

Update here, we're still figuring out what we need to do (if anything) to change our license to incorporate these denied crates. Trying to get this done ASAP.

@dancoombs
Copy link
Collaborator

This should clear up the deny issue, also includes the cargo update so you can just add the reth bump #942

@0xOsiris
Copy link
Author

This should clear up the deny issue, also includes the cargo update so you can just add the reth bump #942

Awesome, just merged upstream!

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have changes to the git submodules. You should revert that change back to head and then run git update submodules to get your local updated and this diff should go away.

(I hate submodules and we're looking at ways to remove these, but they're currently very useful for testing)

Copy link
Collaborator

@dancoombs dancoombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with all the back-and-forth here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants