fix: ignore flaky tests #947
Conversation
andysim3d
requested review from
dancoombs,
dphilipson,
0xfourzerofour and
alex-miao
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -78,29 +78,30 @@ mod tests { | |||
|
|
|||
| use crate::new_alloy_provider; | |||
| fn setup() { | |||
| let server = Server::http("0.0.0.0:8000").unwrap(); | |||
| let server = Server::http("0.0.0.0:9009").unwrap(); | |||
There was a problem hiding this comment.
I'm concerned that this will still be flaky in case something is using this port. Is there a way to let the OS assign an open port and retrieve it after? Sometimes this is done by setting the port to :0
There was a problem hiding this comment.
You may be able to use that and then do .server_addr to get the port it was bound to by the OS
There was a problem hiding this comment.
You may need to use bind and then from_listener to create the server.
There was a problem hiding this comment.
I mark the test to ignore for now. it should only run on local box.
There was a problem hiding this comment.
Okay, we should eventually fix this
[Closes/Fixes] #
Proposed Changes