Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pool): fix pool max ops per sender during replacement #951

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dancoombs
Copy link
Collaborator

@dancoombs dancoombs commented Dec 23, 2024

Fixes: #958

Proposed Changes

  • Consider replacements during max ops per sender enforcement
  • A few small tweaks to reputation logic

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 21 lines in your changes missing coverage. Please review.

Project coverage is 58.92%. Comparing base (27dfb1f) to head (2adb894).

Files with missing lines Patch % Lines
crates/pool/src/mempool/uo_pool.rs 84.26% 14 Missing ⚠️
crates/pool/src/mempool/reputation.rs 56.25% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/pool.rs 96.60% <100.00%> (+0.08%) ⬆️
crates/pool/src/mempool/reputation.rs 83.98% <56.25%> (-0.89%) ⬇️
crates/pool/src/mempool/uo_pool.rs 92.10% <84.26%> (-0.13%) ⬇️
Flag Coverage Δ
unit-tests 58.92% <84.09%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.17% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.51% <84.09%> (+0.30%) ⬆️
provider 19.49% <ø> (ø)
rpc 26.71% <ø> (ø)
sim 77.03% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.61% <ø> (ø)
utils 30.06% <ø> (ø)

@dancoombs dancoombs force-pushed the danc/fix-max-replacement branch 2 times, most recently from 5acef6f to 62a529c Compare December 31, 2024 21:06
@dancoombs dancoombs force-pushed the danc/fix-max-replacement branch from 62a529c to 2adb894 Compare January 3, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pool] Replacement not accounted for during max ops per sender check
1 participant