Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): set fees during bundle sim to ensure base fee is applied #965

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

dancoombs
Copy link
Collaborator

Proposed Changes

  • Bundle simulation should include (1) fees (2) sender EOA
  • Fixes a bug where if the fees are not set then the EVM base fee is set to 0, which impacts final simulation

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 46.31579% with 51 lines in your changes missing coverage. Please review.

Project coverage is 58.80%. Comparing base (ed3d0ae) to head (7adba7a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% 27 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 21 Missing ⚠️
crates/builder/src/task.rs 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/builder/src/bundle_proposer.rs 92.31% <100.00%> (+0.05%) ⬆️
crates/builder/src/bundle_sender.rs 73.33% <100.00%> (ø)
crates/provider/src/traits/entry_point.rs 100.00% <ø> (ø)
crates/provider/src/traits/test_utils.rs 100.00% <100.00%> (ø)
crates/builder/src/task.rs 0.00% <0.00%> (ø)
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% <0.00%> (ø)
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 58.80% <46.31%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.17% <92.68%> (+0.10%) ⬆️
dev ∅ <ø> (∅)
pool 66.20% <ø> (ø)
provider 19.49% <11.11%> (+0.01%) ⬆️
rpc 26.71% <ø> (ø)
sim 77.03% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.61% <ø> (ø)
utils 30.06% <ø> (ø)

@dancoombs dancoombs merged commit 27dfb1f into main Jan 2, 2025
11 checks passed
@dancoombs dancoombs deleted the danc/fix-bundle-sim-basefee branch January 2, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants