forked from react-native-maps/react-native-maps
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add testing section to pull request template & tighten up question co…
…py. (react-native-maps#2097)
- Loading branch information
1 parent
60c562b
commit ed1ec98
Showing
1 changed file
with
27 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,41 +1,53 @@ | ||
| <!-- | ||
| PLEASE DON'T DELETE THIS TEMPLATE UNTIL YOU HAVE READ THE FIRST SECTION. | ||
| PLEASE DON'T DELETE THIS TEMPLATE UNTIL YOU HAVE READ THE FIRST SECTION. | ||
| **What happens if you SKIP this step?** | ||
| **What happens if you SKIP this step?** | ||
| Your pull request will NOT be evaluated! | ||
| Your pull request will NOT be evaluated! | ||
| PLEASE NOTE THAT PRs WITHOUT THE TEMPLATE IN PLACE WILL BE CLOSED RIGHT FROM THE START. | ||
| PLEASE NOTE THAT PRs WITHOUT THE TEMPLATE IN PLACE WILL BE CLOSED RIGHT FROM THE START. | ||
| Thanks for helping us help you! | ||
| Thanks for helping us help you! | ||
| --> | ||
|
|
||
|
|
||
| ### Is there any other PR opened that does the same ? | ||
| ### Does any other open PR do the same thing? | ||
|
|
||
| <!-- | ||
| **Please keep in mind that we apply the FIFO rule for PRs, so if your PR comes after an existing one and there is no compelling reason to merge it instead of the existing one it will be discarded!** | ||
| **Please keep in mind that we aplly the FIFO rule for PRs, so if your PR comes after an existing one and there is no compelling reason to merge it instead of the existing one it will be discarded!** | ||
| If it exists please specify why you opened yours. | ||
| If another PR exists that has similar scope to yours, please specify why you opened yours. | ||
| This could be one of the following (but not limited to) | ||
| - the previous PR is stalled, as it's really old and the author didn't continue working on it | ||
| - there are conflicts with the `master` branch and the author didn't fix them | ||
| - the PR doesn't apply anymore (please specify why) | ||
| - my PR is better (please specify why) | ||
| --> | ||
|
|
||
| (please answer here) | ||
|
|
||
|
|
||
| ### What issue is this PR fixing | ||
| ### What issue is this PR fixing? | ||
|
|
||
| (please link the issue here) | ||
|
|
||
| ### How did you test this PR? | ||
|
|
||
| <!-- | ||
| Please let us know how you have verified that your changes work. | ||
| Ideally, your PR should contain a step-by-step test plan, so that reviewers can easily verify your changes. | ||
| Your PR will have much better chances of being merged if it is straightforward to verify. | ||
| Some questions you might want to think about: | ||
| - Which platform (eg. Android/iOS) & Maps API (eg. Google/Apple) does this change affect, if any? | ||
| - Did you test this on a real device, or in a simulator? | ||
| - Are there any platforms you were not able to test? | ||
| --> | ||
|
|
||
| (please answer here) | ||
|
|
||
| <!-- | ||
| Thanks for your contribution :) | ||
| Thanks for your contribution :) | ||
| --> |