ofproto-dpif-upcall: Do not call dpif_handlers_set() when there is no

handler/revalidator configuration change. dpif_handlers_set(), which dumps all vport from datapath, should not be called constantly. Found by inspection. Signed-off-by: Alex Wang <[email protected]> Acked-by: Ben Pfaff <[email protected]>
aleeee · May 9, 2014 · 380fffe · 380fffe
1 parent bfe4277
commit 380fffe
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
@@ -379,8 +379,6 @@ void
 udpif_set_threads(struct udpif *udpif, size_t n_handlers,
                   size_t n_revalidators)
 {
-    int error;
-
     ovs_assert(udpif);
     ovs_assert(n_handlers && n_revalidators);
 
@@ -390,14 +388,16 @@ udpif_set_threads(struct udpif *udpif, size_t n_handlers,
         udpif_stop_threads(udpif);
     }
 
-    error = dpif_handlers_set(udpif->dpif, n_handlers);
-    if (error) {
-        VLOG_ERR("failed to configure handlers in dpif %s: %s",
-                 dpif_name(udpif->dpif), ovs_strerror(error));
-        return;
-    }
-
     if (!udpif->handlers && !udpif->revalidators) {
+        int error;
+
+        error = dpif_handlers_set(udpif->dpif, n_handlers);
+        if (error) {
+            VLOG_ERR("failed to configure handlers in dpif %s: %s",
+                     dpif_name(udpif->dpif), ovs_strerror(error));
+            return;
+        }
+
         udpif_start_threads(udpif, n_handlers, n_revalidators);
     }
     ovsrcu_quiesce_end();