bridge: Fix use-after-free in bridge_aa_refresh_queue().

Found by LLVM scan-build. Reported-by: Kevin Lo <[email protected]> Signed-off-by: Ben Pfaff <[email protected]> Acked-by: Dennis Flynn <[email protected]>
aleeee · Apr 17, 2015 · 494356b · 494356b
1 parent 577a811
commit 494356b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
@@ -3920,12 +3920,12 @@ static void
 bridge_aa_refresh_queued(struct bridge *br)
 {
     struct ovs_list *list = xmalloc(sizeof *list);
-    struct bridge_aa_vlan *node;
+    struct bridge_aa_vlan *node, *next;
 
     list_init(list);
     ofproto_aa_vlan_get_queued(br->ofproto, list);
 
-    LIST_FOR_EACH(node, list_node, list) {
+    LIST_FOR_EACH_SAFE (node, next, list_node, list) {
         struct port *port;
 
         VLOG_INFO("ifname=%s, vlan=%u, oper=%u", node->port_name, node->vlan,