soundcloud: fix volume preservation

Soundcloud requires rebinding the READY event when a new track is loaded in order to set the volume.
aleves64 · Mar 26, 2016 · efdab32 · efdab32
1 parent 319c529
commit efdab32
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/player/soundcloud.coffee b/player/soundcloud.coffee
@@ -69,6 +69,9 @@ window.SoundCloudPlayer = class SoundCloudPlayer extends Player
             else
                 soundUrl = data.id
             @soundcloud.load(soundUrl, auto_play: true)
+            @soundcloud.bind(SC.Widget.Events.READY, =>
+                @setVolume(VOLUME)
+            )
         else
             console.error('SoundCloudPlayer::load() called but soundcloud is not ready')
 

diff --git a/www/js/player.js b/www/js/player.js
@@ -771,9 +771,14 @@
         } else {
           soundUrl = data.id;
         }
-        return this.soundcloud.load(soundUrl, {
+        this.soundcloud.load(soundUrl, {
           auto_play: true
         });
+        return this.soundcloud.bind(SC.Widget.Events.READY, (function(_this) {
+          return function() {
+            return _this.setVolume(VOLUME);
+          };
+        })(this));
       } else {
         return console.error('SoundCloudPlayer::load() called but soundcloud is not ready');
       }