Skip to content

Commit

Permalink
Update README
Browse files Browse the repository at this point in the history
1. Remove hard coded `/tmp` folder. At the very least, use `NSTemporaryDirectory`. You can also use `URLForDirectory` with `NSItemReplacementDirectory`, but I agree [with NSHipster says](http://nshipster.com/nstemporarydirectory/) that `NSTemporaryDirectory` is fine.
2. Comment out `[db release]` because for 99% of users, now, this isn't appropriate. But `nil` the pointer either way (in MRC, eliminate dangling pointer reference, in ARC, remove your strong reference).
  • Loading branch information
robertmryan committed Oct 4, 2016
1 parent da6ead8 commit 1c4d756
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions README.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ An `FMDatabase` is created with a path to a SQLite database file. This path can
(For more information on temporary and in-memory databases, read the sqlite documentation on the subject: http://www.sqlite.org/inmemorydb.html)

```objc
FMDatabase *db = [FMDatabase databaseWithPath:@"/tmp/tmp.db"];
NSString *path = [NSTemporaryDirectory() stringByAppendingPathComponent:@"tmp.db"];
FMDatabase *db = [FMDatabase databaseWithPath:path];
```
### Opening
Expand All @@ -62,7 +63,8 @@ Before you can interact with the database, it must be opened. Opening fails if
```objc
if (![db open]) {
[db release];
// [db release]; // uncomment this line in manual referencing code; in ARC, this is not necessary/permitted
db = nil;
return;
}
```
Expand Down

0 comments on commit 1c4d756

Please sign in to comment.