🔒 Properly escape aria-hidden images

alexsoyes · May 1, 2020 · 5e63859 · 5e63859
1 parent d91766c
commit 5e63859
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/footer.php b/footer.php
@@ -20,19 +20,19 @@
 			<div class="footer-credits">
 
 				<p class="footer-copyright has-text-align-center">
-					<small class="is-white">
+					<small>
 						<a href="https://moki.me" title="Theme MokiMe" rel="noopener" target="_blank" class="is-white">
 							<?php esc_html_e( 'High performance theme', 'mokime' ); ?>
 						</a>
 						<?php esc_html_e( 'made by ', 'mokime' ); ?>
 						<a href="https://www.security-helpzone.com" title="Security-HelpZone" rel="noopener" target="_blank" class="is-white">SHZ</a>.
 					</small>
-				</p>
+				</p><!-- .footer-copyright -->
 
 			</div><!-- .footer-credits -->
 
 		</div><!-- .section-inner -->
-        <?php endif; ?>
+		<?php endif; ?>
 
 	</div><!-- .header-footer-group  -->
 

diff --git a/template-parts/entry/entry-article.php b/template-parts/entry/entry-article.php
@@ -26,7 +26,7 @@
 
 					<img src="<?php mokime_the_asset( 'icon', 'calendar-outline.svg' ); ?>"
 						 class="card-icons icon" aria-hidden="true"
-						 alt="<?php esc_html_e( 'Published date', 'mokime' ); ?>" />
+						 alt="<?php esc_attr_e( 'Published date', 'mokime' ); ?>" />
 
 					<span class="card-date">
 						<?php $have_no_title = '' === get_the_title(); ?>
@@ -47,7 +47,7 @@ class="card-icons icon" aria-hidden="true"
 
 					<img src="<?php mokime_the_asset( 'icon', 'chatbox-ellipses-outline.svg' ); ?>"
 						 class="card-icons icon" aria-hidden="true"
-						 alt="<?php esc_html_e( 'Comments number', 'mokime' ); ?>">
+						 alt="<?php esc_attr_e( 'Comments number', 'mokime' ); ?>">
 
 					<small class="card-comments color-secondary">
 						<?php

diff --git a/template-parts/entry/entry-comment-number.php b/template-parts/entry/entry-comment-number.php
@@ -6,11 +6,11 @@
 
 		<img src="<?php mokime_the_asset('icon', 'chatbox-ellipses-outline.svg' ); ?>"
 		     class="icon" aria-hidden="true"
-		     alt="<?php esc_html_e( 'Comments number', 'mokime' ); ?>">
+		     alt="<?php esc_attr_e( 'Comments number', 'mokime' ); ?>">
 
 		<?php
 		if ( 0 === $comments_number ) {
-			esc_html_e( 'Add a comment', 'mokime' );
+            esc_attr_e( 'Add a comment', 'mokime' );
 		} else {
 			echo wp_kses_post(
 				sprintf(