chore(engine): adapt postgres backend connection URI (apache#11233)

* chore(engine): adapt postgres backend connection URI * fix tests * Update superset/db_engine_specs/__init__.py Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>
alfonsodg · Oct 14, 2020 · 22d8171 · 22d8171
1 parent 5cbef88
commit 22d8171
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/superset/db_engine_specs/__init__.py b/superset/db_engine_specs/__init__.py
@@ -49,3 +49,7 @@
             and attribute.engine != ""
         ):
             engines[attribute.engine] = attribute
+
+            # populate engine alias name to engine dictionary
+            for engine_alias in attribute.engine_aliases or []:
+                engines[engine_alias] = attribute
diff --git a/superset/db_engine_specs/base.py b/superset/db_engine_specs/base.py
@@ -137,6 +137,7 @@ class BaseEngineSpec:  # pylint: disable=too-many-public-methods
     """Abstract class for database engine specific configurations"""
 
     engine = "base"  # str as defined in sqlalchemy.engine.engine
+    engine_aliases: Optional[Tuple[str]] = None
     engine_name: Optional[
         str
     ] = None  # used for user messages, overridden in child classes

diff --git a/superset/db_engine_specs/postgres.py b/superset/db_engine_specs/postgres.py
@@ -67,6 +67,7 @@ def epoch_to_dttm(cls) -> str:
 
 class PostgresEngineSpec(PostgresBaseEngineSpec):
     engine = "postgresql"
+    engine_aliases = ("postgres",)
     max_column_name_length = 63
     try_remove_schema_from_table_name = False
 

diff --git a/tests/db_engine_specs/postgres_tests.py b/tests/db_engine_specs/postgres_tests.py
@@ -19,6 +19,7 @@
 from sqlalchemy import column, literal_column
 from sqlalchemy.dialects import postgresql
 
+from superset.db_engine_specs import engines
 from superset.db_engine_specs.postgres import PostgresEngineSpec
 from tests.db_engine_specs.base_tests import TestDbEngineSpec
 
@@ -117,3 +118,9 @@ def test_empty_dbapi_cursor_description(self):
         cursor.description = []
         results = PostgresEngineSpec.fetch_data(cursor, 1000)
         self.assertEqual(results, [])
+
+    def test_engine_alias_name(self):
+        """
+        DB Eng Specs (postgres): Test "postgres" in engine spec
+        """
+        self.assertIn("postgres", engines)