Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow invalid NaN value in JSON #2

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Disallow invalid NaN value in JSON #2

merged 1 commit into from
Dec 8, 2021

Conversation

ChrisAntaki
Copy link
Contributor

@ChrisAntaki ChrisAntaki commented Dec 8, 2021 •
edited
Loading

This PR updates the JSON generation to disallow the NaN value, since it makes JSON invalid. Surprisingly, the Python json lib defaults to allowing NaN 🤦‍♀️

@ChrisAntaki
Disallow invalid NaN value in JSON
4e63932 
This PR updates the JSON generation to disallow the `NaN` value, since it makes JSON invalid
@ChrisAntaki
Copy link
Contributor Author

image

@algokittens algokittens merged commit bde5b7a into algokittens:master Dec 8, 2021
algokittens pushed a commit that referenced this pull request Feb 18, 2022
@grexen
Merge pull request #2 from StupidFaces/feature/ExtractSettings
7bbab57 
Feature/extract settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisAntaki @algokittens