Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any info regarding a default timeout on urllib3, it might be the one specified by socket, though I'm not sure about this. In any case I think it's desirable to at least be able to define a more granular timeout, at this level.
I think this implementation keeps backwards compatibility, but please let me know if it doesn't.
Also, I ran tests locally (had to create a trial account for that) and 2 of them fail. I couldn't find the reason but my guess is that it has to do with using a trial account vs an upgraded one. I'm guessing this since I run the whole suite without my modifications and it still fails. Again, please let me know if that's not the case.
I tested this without specifying a timeout - just to see if it doesn't break working code - against our staging servers and it works ok (both queries and documents CRUD).
Let me know what you think.