-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Python 3.9, 3.10 and 3.11 #553
Conversation
Hi @shortcuts , I opened this PR because the other one (#551) is stale for 3 weeks now. However the tests are failing on circleci even though they're all passing locally. Do you have any idea ? |
Hi @shortcuts, |
Hi again, Can someone look at this PR ? |
hey, checking right now for the CI! thanks for the contribution :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! small comment
still trying to figure out the CI issue, not sure if it's related to the fork 🤔
Hi, I fixed both comments :) |
Hi, there' still issues with the pipelines even thought the tests are running locally, do you have an idea on how to solve it ? |
hey @paul-finary, fixed the CI so it should now properly run and report errors, let me know if you still have time to work on that |
fixed some more again, should be more reliable now, still some flaky ones but there seems to be errors related to yield inside async fns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like everything is covered, I'll do an other pass and plan the release ASAP
Describe your change
This PR removes support for python 2.7, adds support for python 3.11 and tests the project against 3.9, 3.10, and 3.11:
yield from
withawait
orreturn
statementsWhat problem is this fixing?
Due to a removed syntax in python 3.11, the package was not working.