Refactor Transport out of Client #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| Algolia Search Client initialization | ||
|
|
||
| @param app_id the application ID you have in your admin interface | ||
| @param api_key a valid API key for the service | ||
| @param hosts_array the list of hosts that you have received for the service | ||
| """ | ||
| if not hosts_array: | ||
| self._transport = Transport() if _transport is None else _transport |
There was a problem hiding this comment.
self._transport = _transport or Transport() 😃
There was a problem hiding this comment.
I guess it's a matter of taste but as I really want it to be None and not False, [] or whatever I prefer to check for None directly
There was a problem hiding this comment.
self._transport = _transport or Transport() 😃
Ruby style ;)
|
Changes Unknown when pulling e15e3de on refactor-async into * on master*. |
additionally fix default client timeouts and resources path Fix default client timeout setup.py: fix resources path Refactor transport layer out of Client
LeoErcolanelli
force-pushed
the
refactor-async
branch
2 times, most recently
from
163a033 to
44e097a
Compare
|
Changes Unknown when pulling 44e097a on refactor-async into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionally fix default client timeouts and resources path