Skip to content

Commit

Permalink
libsrp: fix compile failure
Browse files Browse the repository at this point in the history
commit 4546548 ("kfifo: move struct
kfifo in place") caused a compile failure in ibmvscsitgt.c because it
changed a pointer to kfifo in the libsrp.h structure to a direct
inclusion without including <linux/kfifo.h>.

The fix is simple, just add the include, but how did this happen? This
change, introduced at -rc2, hardly looks like a bug fix, and it clearly
didn't go through linux-next, which would have picked up this compile
failure (it only occurs on ppc because of the ibm virtual scsi target).

[ Apparently all of -mm wasn't in linux-next.. ]

Signed-off-by: James Bottomley <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
James Bottomley authored and torvalds committed Dec 30, 2009
1 parent 6b7b284 commit 75c85a0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions include/scsi/libsrp.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define __LIBSRP_H__

#include <linux/list.h>
#include <linux/kfifo.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_host.h>
#include <scsi/srp.h>
Expand Down

0 comments on commit 75c85a0

Please sign in to comment.