[Android] Remove tar.py and the pack_* targets from gyp

`pack_xwalk_core_library` was created years ago when we had our own Cordova 3 fork and suggested people extracted the xwalk_core_library tarball into its checkout. This has not been the case for a long time, and our release build system does not use any of those `pack_*` targets to create its zip files. Anyone wishing to create a tarball out of the directories in `out/` can do so manually.
alixliu · Sep 9, 2016 · 0a801d1 · 0a801d1
1 parent 5434ca1
commit 0a801d1
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 123 deletions.
diff --git a/tools/tar.py b/tools/tar.py
diff --git a/xwalk.gyp b/xwalk.gyp
@@ -889,8 +889,8 @@
             'xwalk_runtime_client_test_apk',
 
             # For external testing.
-            'pack_xwalk_core_library',
-            'pack_xwalk_shared_library',
+            'xwalk_core_library',
+            'xwalk_shared_library',
             'xwalk_core_library_documentation',
             'xwalk_runtime_lib_apk',
             'xwalk_runtime_lib_lzma_apk',

diff --git a/xwalk_android_app.gypi b/xwalk_android_app.gypi
@@ -72,7 +72,7 @@
       'includes': ['../build/java.gypi'],
     },
     {
-      'target_name': 'prepare_xwalk_app_template',
+      'target_name': 'xwalk_app_template',
       'type': 'none',
       'dependencies': [
         'xwalk_app_runtime_java',
@@ -101,29 +101,5 @@
         },
       ],
     },
-    {
-      'target_name': 'xwalk_app_template',
-      'type': 'none',
-      'dependencies': [
-        'prepare_xwalk_app_template',
-      ],
-      'actions': [
-        {
-          'action_name': 'tar_app_template',
-          'inputs': [
-            'app/android/app_template/AndroidManifest.xml',
-            'tools/tar.py',
-          ],
-          'outputs': [
-            '<(PRODUCT_DIR)/xwalk_app_template.tar.gz',
-            '<(PRODUCT_DIR)/xwalk_app_template_intermediate/always_run',
-          ],
-          'action': [
-            'python', 'tools/tar.py',
-            '<(PRODUCT_DIR)/xwalk_app_template'
-          ],
-        },
-      ],
-    },
   ],
 }
diff --git a/xwalk_core_library_android.gypi b/xwalk_core_library_android.gypi
@@ -68,67 +68,6 @@
         },
       ],
     },
-    {
-      'target_name': 'pack_xwalk_core_library',
-      'type': 'none',
-      'dependencies': [
-        'xwalk_core_library',
-        'xwalk_core_library_src',
-      ],
-      'actions': [
-        {
-          'action_name': 'pack_xwalk_core_library',
-          'message': 'Packaging XwalkCore Library Project.',
-          'inputs': [
-            '<(DEPTH)/xwalk/tools/tar.py',
-          ],
-          'outputs': [
-            '<(PRODUCT_DIR)/pack_xwalk_core_library_intermediate/always_run',
-          ],
-          'action': [
-            'python', 'tools/tar.py',
-            '<(PRODUCT_DIR)/xwalk_core_library'
-          ],
-        },
-        {
-          'action_name': 'pack_xwalk_core_library_src',
-          'message': 'Packaging XwalkCore Library Project Source.',
-          'inputs': [
-            '<(DEPTH)/xwalk/tools/tar.py',
-          ],
-          'outputs': [
-            '<(PRODUCT_DIR)/pack_xwalk_core_library_src_intermediate/always_run',
-          ],
-          'action': [
-            'python', 'tools/tar.py',
-            '<(PRODUCT_DIR)/xwalk_core_library_src'
-          ],
-        },
-      ],
-    },
-    {
-      'target_name': 'pack_xwalk_shared_library',
-      'type': 'none',
-      'dependencies': [
-        'xwalk_shared_library',
-      ],
-      'actions': [
-        {
-          'action_name': 'pack_xwalk_shared_library',
-          'message': 'Packaging XwalkCore Shared Library Project.',
-          'inputs': [
-            '<(DEPTH)/xwalk/tools/tar.py',
-          ],
-          'outputs': [
-            '<(PRODUCT_DIR)/pack_xwalk_shared_library_intermediate/always_run',
-          ],
-          'action': [
-            'python', 'tools/tar.py',
-            '<(PRODUCT_DIR)/xwalk_shared_library'
-          ],
-        },
-      ],
-    },
     {
       'target_name': 'xwalk_core_internal_empty_embedder_apk',
       'type': 'none',