Fix object key problems in batch_delete

aliyun · Dec 23, 2015 · cd2e343 · cd2e343
1 parent 43760dc
commit cd2e343
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/aliyun/oss/protocol.rb b/lib/aliyun/oss/protocol.rb
@@ -919,7 +919,7 @@ def batch_delete_objects(bucket_name, object_names, opts = {})
         body << '<Delete>'
         body << '<Quiet>' << (opts[:quiet]? true : false).to_s << '</Quiet>'
         object_names.each { |k|
-          body << '<Object><Key>' << k << '</Key></Object>'
+          body << '<Object><Key>' << CGI.escapeHTML(k) << '</Key></Object>'
         }
         body << '</Delete>'
 

diff --git a/tests/test_object_key.rb b/tests/test_object_key.rb
@@ -20,7 +20,8 @@ def setup
       simple: 'simple_key',
       chinese: '杭州・中国',
       space: '是 空格 yeah +-/\\&*#',
-      invisible: '' << 1 << 10 << 12 << 7,
+      invisible: '' << 1 << 10 << 12 << 7 << 80 << 99,
+      xml: 'a<b&c>d +'
     }
   end