Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative compilation fix for css + tf2 #2268

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Tentative compilation fix for css + tf2 #2268

merged 7 commits into from
Feb 20, 2025

Conversation

Kenzzer
Copy link
Member

@Kenzzer Kenzzer commented Feb 19, 2025

Same as alliedmodders/hl2sdk-manifests#9

Special note, the define PLATFORM_X86 is now used by valve to refer to both x86 and x86_64. It holds either 32 or 64 value.
So instead of potentially conflicting with whatever valve decides to do with its preprocessor variable, let's just make sure our variable well distinct.

@Kenzzer Kenzzer requested a review from psychonic February 19, 2025 20:47
@peace-maker
Copy link
Member

@Kenzzer
Copy link
Member Author

Kenzzer commented Feb 19, 2025

Ah yes! That makes perfect sense

@psychonic psychonic merged commit 2382453 into master Feb 20, 2025
3 of 4 checks passed
@psychonic psychonic deleted the tf2_sdk2013 branch February 20, 2025 00:51
psychonic pushed a commit that referenced this pull request Feb 20, 2025
* Initial attempt at compiling against tf2_sdk2013

* compilation fix for css

* Switch to AMTL platform arch defines

* Add CBasePlayer forward decl for dods and hl2dm as well

* Update hl2sdk-manifests

* Add dods to CI

* Actually include am-platform.h

---------

Co-authored-by: Kenzzer <[email protected]>
Co-authored-by: Nicholas Hastings <[email protected]>
(cherry picked from commit 2382453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants