Fix _get_existing_parent behaviour #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
fix-ssh-available-locations
branch
5 times, most recently
from
765dc7a to
27278a6
Compare
This commit fixes a wrong behaviour of the `_get_existing_parent` function in the `SSHConnector` class, which led to an infinite loop when the working directory was not existing. This commit also add an integration test for scheduling on remote locations to prevent regressions.
GlassOfWhiskey
force-pushed
the
fix-ssh-available-locations
branch
from
27278a6 to
d085b09
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 65.55% 65.68% +0.12%
==========================================
Files 82 82
Lines 10147 10147
Branches 2397 2397
==========================================
+ Hits 6652 6665 +13
+ Misses 3068 3056 -12
+ Partials 427 426 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a wrong behaviour of the
_get_existing_parentfunction in theSSHConnectorclass, which led to an infinite loop when the working directory was not existing.This commit also add an integration test for scheduling on remote locations to prevent regressions.