Address PR comments:

* create networkName to pass to SDK * Refac networkFromString too avoid redundancy
alphaquark · May 1, 2020 · ee00380 · ee00380
1 parent 5f3568d
commit ee00380
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/dist/nft-card.min.js b/dist/nft-card.min.js
diff --git a/dist/nft-card.min.js.map b/dist/nft-card.min.js.map
diff --git a/src/nft-card.ts b/src/nft-card.ts
@@ -172,8 +172,8 @@ export class NftCard extends LitElement {
     // Get the web3 provider
     this.provider = getProvider()
 
-    this.network = networkFromString(this.network)
-    this.seaport = new OpenSeaPort(this.provider, { networkName: this.network })
+    const networkName = networkFromString(this.network)
+    this.seaport = new OpenSeaPort(this.provider, { networkName })
 
     try {
       this.asset = await this.seaport.api.getAsset({

diff --git a/src/utils.ts b/src/utils.ts
@@ -84,11 +84,10 @@ export const networkFromId = (id: string) => {
 
 export const networkFromString = (name: string) => {
   switch (name) {
-    case 'mainnet':
-    case 'main':
-      return Network.Main
     case 'rinkeby':
       return Network.Rinkeby
+    case 'mainnet':
+    case 'main':
     default:
       return Network.Main
   }