Fix permissions and job dependencies in release workflow (angr#1311)

* Fix permissions and job dependencies in release workflow * Use release branch to clone angr management * Use release version in gh release command
alsgh5016 · Aug 13, 2024 · a85d863 · a85d863
1 parent a3c4dd5
commit a85d863
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/pyinstaller-build.yml b/.github/workflows/pyinstaller-build.yml
@@ -24,6 +24,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.inputs.version }}
       - uses: actions/setup-python@v4
         with:
           python-version: "3.12"

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -16,12 +16,16 @@ jobs:
       version: ${{ github.event.inputs.version }}
   deploy:
     runs-on: ubuntu-22.04
+    needs: build
+    permissions:
+      contents: write
+      id-token: write
     steps:
       - name: Download artifacts
         uses: actions/download-artifact@v4
       - name: Make release
         run: >
-          gh release create nightly \
+          gh release create ${{ github.event.inputs.version }} \
             --repo angr/angr-management \
             --title "angr management ${{ github.event.inputs.version }}" \
             --notes "$RELEASE_NOTES" \