Skip to content

Commit

Permalink
added more comments for clarity as per review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
deveshdama committed Sep 5, 2024
1 parent e75c4d6 commit 684f25d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ spec:
name: http
protocol: HTTP
hosts:
- "test.dev.azureservicemesh.io"
- "test.dev.azureservicemesh.io" # this should match your DNS name
- port:
number: 443
name: https-bookinfo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ kubectl label namespace default istio.io/rev=$revision

## Steps
### 1. Setup DNS record
Setup a DNS record for the external-ip address for the external ingressgateway service with your cloud provider. In this example, I set up 4.153.8.39 with test.dev.azureservicemesh.io
Set up a DNS record for the `EXTERNAL-IP` address of the external ingressgateway service with your cloud provider. In this example, we are setting up the DNS record for `4.153.8.39` with `test.dev.azureservicemesh.io`.

Run the following command to retrieve the external IP address of the ingress gateway:
```shell
kubectl get svc -n aks-istio-ingress
```
Expand Down Expand Up @@ -71,6 +73,7 @@ reviews-v2-7d79d5bd5d-8zzqd 2/2 Running 0 2m41s
reviews-v3-7dbcdcbc56-m8dph 2/2 Running 0 2m41s
```
### 3. Configure ingress gateway and virtual service
Before deploying the `virtualservice` and `gateway` resources, make sure to update the `hosts` files to match your own DNS name.
```shell
kubectl apply -f gateway.yaml
kubectl apply -f virtualservice.yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
namespace: default
spec:
hosts:
- test.dev.azureservicemesh.io
- test.dev.azureservicemesh.io # this should match your DNS name
gateways:
- bookinfo-gateway
http:
Expand Down

0 comments on commit 684f25d

Please sign in to comment.