Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Saverio Proto <[email protected]>
  • Loading branch information
deveshdama and zioproto authored Sep 6, 2024
1 parent 699142c commit 8f37b92
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ this should print `<title>Simple Bookstore App</title>`
Create a ConfigMap with the name `istio-shared-configmap-<asm-revision>` in the `aks-istio-system` namespace to set `ingressService` and `ingressSelector`. For example, if your cluster is running asm-1-21 revision of mesh, then the ConfigMap needs to be named as istio-shared-configmap-asm-1-21. Mesh configuration has to be provided within the data section under mesh.

```shell
kubectl apply -f configmap.yaml
cat configmap.yaml | sed -e "s/<asm-revision>/${revision}/" | kubectl apply -f -
```

### 5. Install cert-manager
Expand All @@ -123,10 +123,11 @@ cert-manager-webhook-575479ff47-d87pf 1/1 Running 0 72s
### 6. Setup cluster-issuer and Certificate resources
Set your email address in `cluster-issuer.yaml` that you'd like to register with ACME server.
```shell
kubectl apply -f cluster-issuer.yaml
EMAIL=email
cat cluster-issuer.yaml | sed -e "s/[email protected]/${EMAIL}/" | kubectl apply -f -
kubectl apply -f certificate.yaml
```
This should create k8s secret `bookinfo-certs` in `aks-istio-ingress` ns as requested by the certificate resource created above.
This should create k8s secret `bookinfo-certs` in `aks-istio-ingress` namespace as requested by the certificate resource created above.

```shell
kubectl get secret -n aks-istio-ingress
Expand Down

0 comments on commit 8f37b92

Please sign in to comment.