Skip to content

Commit

Permalink
Add pullapprove (GoogleChrome#463)
Browse files Browse the repository at this point in the history
* Add pullapprove config file.

* remove GH Codeowners

* Add extensions team to pullapprove.

* Add eng team as fallback approvers for extensions content.
  • Loading branch information
robdodson authored Feb 25, 2021
1 parent 9defc9b commit 83d45ca
Show file tree
Hide file tree
Showing 2 changed files with 83 additions and 43 deletions.
43 changes: 0 additions & 43 deletions .github/CODEOWNERS

This file was deleted.

83 changes: 83 additions & 0 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
version: 3

groups:
# Extensions
# Handles any changes related to extensions, web store, and chrome apps.
# By default Simeon and Andy will be tagged in as reviewers, but anyone
# on the dcc-extensions, dcc-content, or dcc-approvers team can approve PRs.
content:
reviewers:
users:
- awfuchs
- dotproto
teams:
# Prefix a username or team with ~ to include them in the reviewer pool
# but skip them when sending review requests.
- ~dcc-extensions
- ~dcc-content
- ~dcc-eng
- ~dcc-approvers
reviews:
# Assign all possible reviewers
request: 99
conditions:
- >
files.include('site/en/docs/apps/*') or
files.include('site/en/docs/extensions/*') or
files.include('site/en/docs/webstore/*') or
files.include('site/_data/docs/apps/*') or
files.include('site/_data/docs/extensions/*') or
files.include('site/_data/docs/webstore/*') or
files.include('site/_data/i18n/docs/apps.yml') or
files.include('site/_data/i18n/docs/extensions.yml') or
files.include('site/_data/i18n/docs/webstore.yml')
# Content
# Handles any changes related to site content.
content:
reviewers:
teams:
- dcc-content
- ~dcc-eng
- ~dcc-approvers
reviews:
# Assign everyone on the content team for reviews.
request: 99
conditions:
# Only tag the content team if the review has not been handled by
# one of the prior teams.
- 'len(groups.active) == 0'
- >
files.include('site/en/*') or
files.include('redirects.yaml') or
files.include('site/_data/docs/*') or
files.include('site/_data/i18n/*') or
files.include('site/_data/authorsData.json') or
files.include('site/_data/supportedTags.json')
# Code
# Handles any changes to programmatic files.
code:
reviewers:
teams:
- dcc-eng
reviews:
# The number of people who should be requested for review at any given
# time. Default is 1.
request: 2
conditions:
# The engineering team is the default owner for any code related files.
- >
contains_any_globs(files, [
'**/*.js',
'**/*.css',
'**/*.scss',
'**/*.html',
'**/*.htm',
'**/*.njk',
'**/*.toml',
'**/*.sh'
]) or
files.include('*.yaml').exclude('redirects.yaml') or
files.include('*.yml').exclude('site/_data/docs/*').exclude('site/_data/i18n/*') or
files.include('*.json').exclude('site/_data/authorsData.json').exclude('site/_data/supportedTags.json')

0 comments on commit 83d45ca

Please sign in to comment.