Skip to content

Commit

Permalink
block: Remove unused blk_pm_*() function definitions
Browse files Browse the repository at this point in the history
Commit a1ce35f ("block: remove dead elevator code") removed the last
callers of blk_pm_requeue_request(), blk_pm_add_request() and
blk_pm_put_request(). Hence remove the definitions of these functions.
Removing these functions removes all users of the struct request nr_pending
member. Hence also remove 'nr_pending'. Note: 'nr_pending' is no longer
used since commit 7cedffe ("block: Make blk_get_request() block for
non-PM requests while suspended").

Cc: Alan Stern <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Signed-off-by: Bart Van Assche <[email protected]>
Reviewed-by: Chaitanya Kulkarni <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
bvanassche authored and axboe committed Feb 22, 2021
1 parent 31caf8b commit 9fb4071
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 39 deletions.
38 changes: 0 additions & 38 deletions block/blk-pm.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,31 +21,6 @@ static inline void blk_pm_mark_last_busy(struct request *rq)
if (rq->q->dev && !(rq->rq_flags & RQF_PM))
pm_runtime_mark_last_busy(rq->q->dev);
}

static inline void blk_pm_requeue_request(struct request *rq)
{
lockdep_assert_held(&rq->q->queue_lock);

if (rq->q->dev && !(rq->rq_flags & RQF_PM))
rq->q->nr_pending--;
}

static inline void blk_pm_add_request(struct request_queue *q,
struct request *rq)
{
lockdep_assert_held(&q->queue_lock);

if (q->dev && !(rq->rq_flags & RQF_PM))
q->nr_pending++;
}

static inline void blk_pm_put_request(struct request *rq)
{
lockdep_assert_held(&rq->q->queue_lock);

if (rq->q->dev && !(rq->rq_flags & RQF_PM))
--rq->q->nr_pending;
}
#else
static inline int blk_pm_resume_queue(const bool pm, struct request_queue *q)
{
Expand All @@ -55,19 +30,6 @@ static inline int blk_pm_resume_queue(const bool pm, struct request_queue *q)
static inline void blk_pm_mark_last_busy(struct request *rq)
{
}

static inline void blk_pm_requeue_request(struct request *rq)
{
}

static inline void blk_pm_add_request(struct request_queue *q,
struct request *rq)
{
}

static inline void blk_pm_put_request(struct request *rq)
{
}
#endif

#endif /* _BLOCK_BLK_PM_H_ */
1 change: 0 additions & 1 deletion include/linux/blkdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,6 @@ struct request_queue {
#ifdef CONFIG_PM
struct device *dev;
enum rpm_status rpm_status;
unsigned int nr_pending;
#endif

/*
Expand Down

0 comments on commit 9fb4071

Please sign in to comment.