Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed build setting and fixed multiple line issue #41

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

mrajatttt
Copy link
Contributor

Issue Number:
#37
#40

Description:

What are the changes? Why are we making them?

  • Explicitly setting BUILD_LIBRARY_FOR_DISTRIBUTION to true
  • Fixed multiple line issue where UI was appending \ whenever there was multiple lines in a text because we used to modify the message in websocketmanager class.

Functional backward compatibility:

Does this change introduce backwards incompatible changes? [YES/NO] NO

Does this change introduce any new dependency? [YES/NO] NO


Testing:

Is the code unit tested?

Have you tested the changes with a sample UI (e.g. iOS Mobile Chat Example)?

List manual testing steps:

  • Add Steps below:

Here are a list of manual test cases to run through:

  • Initiating chat and connecting with an agent
  • Retrieving transcript
  • Disconnecting from chat
  • Sending a message to the agent
    • See typing bubbles on agent side
    • See read/delivered receipt on client side
    • Receiving a message from the agent
    • See typing bubbles on client side
    • See read/delivered receipt on agent side
    • Sending an attachment to the agent (try .txt, .pdf, .jpg)
    • Preview the attachment on click
    • Receiving an attachment from the agent
    • Preview the attachment on click
  • Close the application (Without ending chat) → open app again → Start chat → Should Retrieve transcript from a previous chat session

@mrajatttt mrajatttt merged commit b434175 into main Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUILD_LIBRARY_FOR_DISTRIBUTION not set to Yes on build settings Addition of Privacy Manifest
3 participants