Fix issue causing lobs to skip some bytes when doing partial reads #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
previously approved these changes
Aug 12, 2020
test/test_ion_text.cpp
Outdated
| } | ||
|
|
||
| // regression test for https://github.com/amzn/ion-c/issues/188 | ||
| TEST(IonTextblob, CanFullyReadBlobUsingPartialReadsAfterReadingSize) { |
|
I've refactored a bit to DRY some and also added equivalent tests for Ion binary. The same bug does not exist for the binary reader. |
tgregg
approved these changes
Aug 13, 2020
|
thanks for fixing that so quickly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
Also adds regression tests as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.