Replace Assertion Failure with Error for Premature Container Ends #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces what is an assertion failure with a returned error when the user attempts to step out of an Ion Container that was not completed before the stream ended. The issue is causing ion-python loads to hang for this case. GH #355
jobarr-amzn
previously approved these changes
Jan 7, 2025
|
Update: I cross-checked this behavior with the text reader. Apparently the text reader raises on error on reader_next. I will add that as well. |
jobarr-amzn
previously approved these changes
Jan 7, 2025
|
I'm going to need to revisit this as my change appears to be causing build failures. |
I realized the text reader also throws an error when the user tries to get the next value from within the container. That seems right to me as well, so I added a check there and then a test to prove consistency.
rmarrowstone
force-pushed
the
premature-container-end-fix
branch
from
e5e5f1e to
6332473
Compare
tgregg
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces what is an assertion failure with a returned
error when the user attempts to step out of an Ion Container that
was not completed before the stream ended.
The issue is causing ion-python loads to hang for this case.
GH #355
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.