Skip to content

Commit

Permalink
platform/x86: pcengines-apuv2: Spelling fixes in the driver
Browse files Browse the repository at this point in the history 
Mainly does:
 - capitalize gpio and bios to GPIO and BIOS
 - capitalize beginning of comments
 - add periods in multi-line comments

Signed-off-by: Andy Shevchenko <[email protected]>
  • Loading branch information
@andy-shev
andy-shev committed Dec 20, 2019
1 parent 3d00da1 commit 02abbda
Showing 1 changed file with 20 additions and 20 deletions.
40 changes: 20 additions & 20 deletions drivers/platform/x86/pcengines-apuv2.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

/*
* PC-Engines APUv2/APUv3 board platform driver
* for gpio buttons and LEDs
* for GPIO buttons and LEDs
*
* Copyright (C) 2018 metux IT consult
* Author: Enrico Weigelt <[email protected]>
Expand All @@ -23,10 +23,10 @@

/*
* NOTE: this driver only supports APUv2/3 - not APUv1, as this one
* has completely different register layouts
* has completely different register layouts.
*/

/* register mappings */
/* Register mappings */
#define APU2_GPIO_REG_LED1 AMD_FCH_GPIO_REG_GPIO57
#define APU2_GPIO_REG_LED2 AMD_FCH_GPIO_REG_GPIO58
#define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1
Expand All @@ -35,7 +35,7 @@
#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0
#define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51

/* order in which the gpio lines are defined in the register list */
/* Order in which the GPIO lines are defined in the register list */
#define APU2_GPIO_LINE_LED1 0
#define APU2_GPIO_LINE_LED2 1
#define APU2_GPIO_LINE_LED3 2
Expand All @@ -44,7 +44,7 @@
#define APU2_GPIO_LINE_MPCIE2 5
#define APU2_GPIO_LINE_MPCIE3 6

/* gpio device */
/* GPIO device */

static int apu2_gpio_regs[] = {
[APU2_GPIO_LINE_LED1] = APU2_GPIO_REG_LED1,
Expand Down Expand Up @@ -72,7 +72,7 @@ static const struct amd_fch_gpio_pdata board_apu2 = {
.gpio_names = apu2_gpio_names,
};

/* gpio leds device */
/* GPIO LEDs device */

static const struct gpio_led apu2_leds[] = {
{ .name = "apu:green:1" },
Expand Down Expand Up @@ -100,7 +100,7 @@ static struct gpiod_lookup_table gpios_led_table = {
}
};

/* gpio keyboard device */
/* GPIO keyboard device */

static struct gpio_keys_button apu2_keys_buttons[] = {
{
Expand Down Expand Up @@ -129,12 +129,12 @@ static struct gpiod_lookup_table gpios_key_table = {
}
};

/* board setup */
/* Board setup */

/* note: matching works on string prefix, so "apu2" must come before "apu" */
/* Note: matching works on string prefix, so "apu2" must come before "apu" */
static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {

/* APU2 w/ legacy bios < 4.0.8 */
/* APU2 w/ legacy BIOS < 4.0.8 */
{
.ident = "apu2",
.matches = {
Expand All @@ -143,7 +143,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
/* APU2 w/ legacy bios >= 4.0.8 */
/* APU2 w/ legacy BIOS >= 4.0.8 */
{
.ident = "apu2",
.matches = {
Expand All @@ -152,7 +152,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
/* APU2 w/ maainline bios */
/* APU2 w/ mainline BIOS */
{
.ident = "apu2",
.matches = {
Expand All @@ -162,7 +162,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
.driver_data = (void *)&board_apu2,
},

/* APU3 w/ legacy bios < 4.0.8 */
/* APU3 w/ legacy BIOS < 4.0.8 */
{
.ident = "apu3",
.matches = {
Expand All @@ -171,7 +171,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
/* APU3 w/ legacy bios >= 4.0.8 */
/* APU3 w/ legacy BIOS >= 4.0.8 */
{
.ident = "apu3",
.matches = {
Expand All @@ -180,7 +180,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
/* APU3 w/ mainline bios */
/* APU3 w/ mainline BIOS */
{
.ident = "apu3",
.matches = {
Expand All @@ -189,7 +189,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
/* APU4 w/ legacy bios < 4.0.8 */
/* APU4 w/ legacy BIOS < 4.0.8 */
{
.ident = "apu4",
.matches = {
Expand All @@ -198,7 +198,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
/* APU4 w/ legacy bios >= 4.0.8 */
/* APU4 w/ legacy BIOS >= 4.0.8 */
{
.ident = "apu4",
.matches = {
Expand All @@ -207,7 +207,7 @@ static const struct dmi_system_id apu_gpio_dmi_table[] __initconst = {
},
.driver_data = (void *)&board_apu2,
},
/* APU4 w/ mainline bios */
/* APU4 w/ mainline BIOS */
{
.ident = "apu4",
.matches = {
Expand Down Expand Up @@ -250,7 +250,7 @@ static int __init apu_board_init(void)

id = dmi_first_match(apu_gpio_dmi_table);
if (!id) {
pr_err("failed to detect apu board via dmi\n");
pr_err("failed to detect APU board via DMI\n");
return -ENODEV;
}

Expand Down Expand Up @@ -289,7 +289,7 @@ module_init(apu_board_init);
module_exit(apu_board_exit);

MODULE_AUTHOR("Enrico Weigelt, metux IT consult <[email protected]>");
MODULE_DESCRIPTION("PC Engines APUv2/APUv3 board GPIO/LED/keys driver");
MODULE_DESCRIPTION("PC Engines APUv2/APUv3 board GPIO/LEDs/keys driver");
MODULE_LICENSE("GPL");
MODULE_DEVICE_TABLE(dmi, apu_gpio_dmi_table);
MODULE_ALIAS("platform:pcengines-apuv2");
Expand Down

0 comments on commit 02abbda

Please sign in to comment.