xfs: fix double IRELE in xfs_dqrele_inode

xfs_dqrele_inode calls xfs_iput to release the ilock and a reference and then also calls IRELE which does a second decrement of the reference count. This leads to a premature freeing of inodes when quotas were turned off while the filesystem was mounted. Thanks to Utako Kusaka for reporting the bug and provinding a good testcase. Signed-off-by: Christoph Hellwig <[email protected]> Reported-by: Utako Kusaka <[email protected]> Reviewed-by: Alex Elder <[email protected]> Signed-off-by: Alex Elder <[email protected]>
ambv · Oct 13, 2009 · 05277c7 · 05277c7
1 parent d080070
commit 05277c7
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/fs/xfs/quota/xfs_qm_syscalls.c b/fs/xfs/quota/xfs_qm_syscalls.c
@@ -876,7 +876,6 @@ xfs_dqrele_inode(
 		ip->i_gdquot = NULL;
 	}
 	xfs_iput(ip, XFS_ILOCK_EXCL);
-	IRELE(ip);
 
 	return 0;
 }