isofs: release buffer head before return

Release the buffer_head before returning error code in do_isofs_readdir() and isofs_find_entry(). Fixes: 2deb1ac ("isofs: fix access to unallocated memory when reading corrupted filesystem") Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Pan Bian <[email protected]> Signed-off-by: Jan Kara <[email protected]>
ambv · Jan 25, 2021 · 0a6dc67 · 0a6dc67
1 parent a4db107
commit 0a6dc67
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c
@@ -152,6 +152,7 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,
 			printk(KERN_NOTICE "iso9660: Corrupted directory entry"
 			       " in block %lu of inode %lu\n", block,
 			       inode->i_ino);
+			brelse(bh);
 			return -EIO;
 		}
 

diff --git a/fs/isofs/namei.c b/fs/isofs/namei.c
@@ -102,6 +102,7 @@ isofs_find_entry(struct inode *dir, struct dentry *dentry,
 			printk(KERN_NOTICE "iso9660: Corrupted directory entry"
 			       " in block %lu of inode %lu\n", block,
 			       dir->i_ino);
+			brelse(bh);
 			return 0;
 		}